fix(a11y): focus monitor not identifying touch focus inside shadow root #17167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`FocusMonitor` uses a `touchstart` listener on the `document` to identify when an element was focused via touch. The problem is that if an element is inside the shadow DOM, the `event.target` will be set to the shadow root. These changes use `composedPath` to get the event target which accounts for the shadow DOM.
crisbeto
added
P3
googlebot
added
the
cla: yes
mmalerba
approved these changes
Sep 23, 2019
mmalerba
added
pr: lgtm
action: merge
mmalerba
pushed a commit
that referenced
this pull request
Oct 8, 2019
…ot (#17167) `FocusMonitor` uses a `touchstart` listener on the `document` to identify when an element was focused via touch. The problem is that if an element is inside the shadow DOM, the `event.target` will be set to the shadow root. These changes use `composedPath` to get the event target which accounts for the shadow DOM. (cherry picked from commit 3673f3d)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FocusMonitoruses atouchstartlistener on thedocumentto identify when an element was focused via touch. The problem is that if an element is inside the shadow DOM, theevent.targetwill be set to the shadow root. These changes usecomposedPathto get the event target which accounts for the shadow DOM.Note: I was unable to write a test that captures the error, because our fake touch events weren't behaving similarly to the ones the browser dispatches from the shadow DOM.