build: update to chalk version that works in circleci #17193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Updates to a chalk version that works in CircleCI (due to a more recent dependency on `supports-color`). Since the latest chalk version brings official typings that do not declare individual colors as ESM exports, we need to go through the default export. This is the official expected behavior with `chalk` according to: chalk/chalk#215.
devversion
force-pushed
the
build/update-chalk-version-works-circleci
branch
from
1c2704c to
047d39c
Compare
devversion
added
pr: merge safe
target: patch
|
@josephperrott This fixes that our colors are not displayed in the CI. Also it's generally good updating the |
josephperrott
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Sep 30, 2019
Updates to a chalk version that works in CircleCI (due to a more recent dependency on `supports-color`). Since the latest chalk version brings official typings that do not declare individual colors as ESM exports, we need to go through the default export. This is the official expected behavior with `chalk` according to: chalk/chalk#215. (cherry picked from commit 7cd78ff)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to a chalk version that works in CircleCI (due to a more recent
dependency on
supports-color).Since the latest chalk version brings official typings that do not declare
individual colors as ESM exports, we need to go through the default export.
This is the official expected behavior with
chalkaccording to: chalk/chalk#215.