build: generate metadata for cdk keycodes entry-point #17203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to use "ng_module" for building the `keycodes` entry-point since we want metadata to be generated for keycode constants. This is necessary because some of these constants are statically used in component/directive metadata (e.g. chips) and NGC needs to be able to evaluate these at compile time.
googlebot
added
the
cla: yes
devversion
added
pr: merge safe
target: patch
jelbourn
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Sep 30, 2019
We need to use "ng_module" for building the `keycodes` entry-point since we want metadata to be generated for keycode constants. This is necessary because some of these constants are statically used in component/directive metadata (e.g. chips) and NGC needs to be able to evaluate these at compile time. (cherry picked from commit 8584487)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use "ng_module" for building the
keycodesentry-point since wewant metadata to be generated for keycode constants. This is necessary
because some of these constants are statically used in component/directive
metadata (e.g. chips) and NGC needs to be able to evaluate these at compile time.