Skip to content

Conversation

devversion
Copy link
Member

@devversion devversion commented Nov 4, 2016

  • The Browserstack versions are always fetched from the cache, and never update them self. The TunnelWrapper package does not update the binaries if a newer version is available (that's not implemented yet here)

  • It might be good to get rid of that wrapper in the future and do something similar to the saucelabs scripts

Note: Right now older versions can cause issues like

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 4, 2016
@jelbourn
Copy link
Member

jelbourn commented Nov 4, 2016

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 4, 2016
@jelbourn jelbourn merged commit bec1519 into angular:master Nov 8, 2016
rolandjitsu pushed a commit to rolandjitsu/material2 that referenced this pull request Nov 10, 2016
@devversion devversion deleted the chore/browserstack-fixes branch November 12, 2016 12:09
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants