fix(drag-drop): unable to drop into connected list inside shadow DOM and ngIf #17424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and ngIf In angular#16899 we added some logic to account for connected drop lists inside the shadow DOM, however the logic was put in the constructor which is too early since the element might not be moved into the shadow DOM yet, if it is inserted through something like `ngFor` or `ngIf`. These changes fix the issue by resolving the shadow root lazily the first time it is requested, which should be more than enough time for the element to have been moved into the shadow DOM. Fixes angular#17422.
crisbeto
added
P2
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #16899 we added some logic to account for connected drop lists inside the shadow DOM, however the logic was put in the constructor which is too early since the element might not be moved into the shadow DOM yet, if it is inserted through something like
ngFororngIf.These changes fix the issue by resolving the shadow root lazily the first time it is requested, which should be more than enough time for the element to have been moved into the shadow DOM.
Fixes #17422.