build: reduce manual setup for entry-points of packages #17460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
added
pr: merge safe
target: major
devversion
force-pushed
the
build/reduce-entry-point-manual-setup-config
branch
from
00b8e87 to
e8a0641
Compare
josephperrott
added
pr: lgtm
action: merge
|
@devversion needs rebase |
|
Just needs rebase |
devversion
force-pushed
the
build/reduce-entry-point-manual-setup-config
branch
from
e8a0641 to
a3f02a6
Compare
Reduces the manual setup for entry-poitns of packages. With this change, we no longer need to update the dev-app system config if we add/remove entry-points. We basically only need to configure entry-points in the `config.bzl` file. Though this is not 100% complete yet, because we still have legacy karma tests which need another system config. The bazel karma tests do not need this anymore.
devversion
force-pushed
the
build/reduce-entry-point-manual-setup-config
branch
from
a3f02a6 to
b8d4a15
Compare
mmalerba
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the manual setup for entry-poitns of packages. With
this change, we no longer need to update the dev-app system
config if we add/remove entry-points.
We basically only need to configure entry-points in the
config.bzlfile. Though this is not 100% complete yet,because we still have legacy karma tests which need another
system config. The bazel karma tests do not need this anymore.