Skip to content

docs(cdk/testing): Add documentation for harness authors #17484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 24, 2019
Merged

docs(cdk/testing): Add documentation for harness authors #17484

merged 3 commits into from
Oct 24, 2019

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful pr: merge safe target: major This PR is targeted for the next major release labels Oct 23, 2019
@mmalerba mmalerba added this to the 9.0.0 milestone Oct 23, 2019
@mmalerba mmalerba requested a review from jelbourn October 23, 2019 19:12
@mmalerba mmalerba requested a review from devversion as a code owner October 23, 2019 19:12
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 23, 2019
@mmalerba mmalerba force-pushed the harness-authoring-docs branch from 6ae9221 to 3a6d6d4 Compare October 23, 2019 19:12
@jelbourn
Copy link
Member

Super good docs overall, here's my proposed edits: jelbourn@9fd3999

(mostly for active voice, some minor grammar / structure)

@mmalerba mmalerba force-pushed the harness-authoring-docs branch from 3a6d6d4 to 9f524df Compare October 24, 2019 18:09
@mmalerba
Copy link
Contributor Author

Accepted the proposed edits and added a few more small ones on top

jelbourn
jelbourn approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added docs This issue is related to documentation pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 24, 2019
@mmalerba mmalerba merged commit c6bcce9 into angular:master Oct 24, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: major This PR is targeted for the next major release

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mmalerba @jelbourn @googlebot