Skip to content

Conversation

mina-skunk
Copy link
Contributor

issue #17487

@mina-skunk mina-skunk requested a review from jelbourn as a code owner October 23, 2019 21:57
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Oct 23, 2019
@mina-skunk
Copy link
Contributor Author

@googlebot I signed it!

1 similar comment
@mina-skunk
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Oct 23, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Oct 24, 2019
@jelbourn
Copy link
Member

For the commit message: I would actually consider this a fix rather than a feature since it should have always done this

@mina-skunk
Copy link
Contributor Author

commit message changed

@jelbourn jelbourn changed the title feat(card): add card content selectors fix(card): add card content selectors Oct 24, 2019
@jelbourn jelbourn removed the merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed label Oct 24, 2019
@jelbourn jelbourn merged commit 9b19e6a into angular:master Dec 3, 2019
@mina-skunk mina-skunk deleted the card-selector branch December 3, 2019 16:39
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants