Skip to content

fix(sidenav): not destroying custom QueryList #17619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2019
Merged

fix(sidenav): not destroying custom QueryList #17619

merged 1 commit into from
Nov 11, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 6, 2019

We maintain a custom QuestList called _drawers which contains only the drawers that belong to the particular container, however we never destroy it.

@crisbeto
fix(sidenav): not destroying custom QueryList
8884559 
We maintain a custom `QuestList` called `_drawers` which contains only the drawers that belong to the particular container, however we never destroy it.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 6, 2019
@crisbeto crisbeto requested a review from mmalerba as a code owner November 6, 2019 00:26
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 6, 2019
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 6, 2019
@mmalerba mmalerba merged commit 39c0074 into angular:master Nov 11, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @googlebot @mmalerba