Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove example package workaround for flat module bundle #17642

Merged

Conversation

@devversion
Copy link
Member

devversion commented Nov 7, 2019

We no longer need the flat module bundle workaround for the
components-examples. This is because we no longer use a
flat module bundle for this package as we release with ngtsc.

We no longer need the flat module bundle workaround for the
`components-examples`. This is because we no longer use a
flat module bundle for this package as we release with ngtsc.
@devversion devversion requested a review from angular/dev-infra-components as a code owner Nov 7, 2019
@googlebot googlebot added the cla: yes label Nov 7, 2019
Copy link
Member

jelbourn left a comment

LGTM

Copy link
Member

josephperrott left a comment

LGTM

@mmalerba mmalerba merged commit 2e03208 into angular:master Nov 7, 2019
11 checks passed
11 checks passed
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.