feat(tooltip): add theming flexibility #17643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
FrankiePo
commented
Nov 7, 2019
| .mat-tooltip { | ||
| background: mat-color($mat-grey, 700, 0.9); | ||
| background: mat-color($background, tooltip, 0.9); |
There was a problem hiding this comment.
Is it better to move opacity to global pallete?
FrankiePo
force-pushed
the
tooltip-theming
branch
2 times, most recently
from
134127d to
e8db677
Compare
crisbeto
reviewed
Nov 17, 2019
| @@ -704,6 +705,7 @@ $mat-dark-theme-background: ( | |||
| disabled-button-toggle: black, | |||
| unselected-chip: map_get($mat-grey, 700), | |||
| disabled-list-option: black, | |||
| tooltip: rgba(map_get($mat-grey, 700), 0.9), | |||
There was a problem hiding this comment.
This will throw a compilation error if $mat-grey 700 resolves to a CSS variable.
There was a problem hiding this comment.
I moved opacity inside _tooltip-theme.scss
so mat-color will handle css variables
FrankiePo
force-pushed
the
tooltip-theming
branch
from
e8db677 to
baf6e32
Compare
crisbeto
added
P3
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.