Skip to content

demo(google-map): minor clarity tweaks to the dev-app demo #17647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2019
Merged

demo(google-map): minor clarity tweaks to the dev-app demo #17647

merged 1 commit into from
Nov 8, 2019

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Nov 7, 2019 •
edited
Loading

  • remove infoWindowPosition since it is not actually used
    • and passing in undefined to the Input is a little confusing
    • also it's type doesn't match the position Input's types
  • make the first marker visible on initial load
  • make the first marker clickable to make the demo less confusing
  • use more semantic HTML

@Splaktar Splaktar added pr: merge safe P4 A relatively minor issue that is not relevant to core functions target: minor This PR is targeted for the next minor release labels Nov 7, 2019
@Splaktar Splaktar requested a review from mbehrlich November 7, 2019 18:55
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 7, 2019
@Splaktar
demo(google-map): minor clarity tweaks to the dev-app demo
1f638ad 
- remove infoWindowPosition since it is not actually used
  - and passing in undefined to the @input is a little confusing
  - also it's type doesn't match the position @input's types
- make the first marker visible on initial load
- make the first marker clickable to make the demo less confusing
- use more semantic HTML
mbehrlich
mbehrlich approved these changes Nov 8, 2019
View reviewed changes
Copy link
Collaborator

@mbehrlich mbehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Splaktar Splaktar added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 8, 2019
@mmalerba mmalerba merged commit a5cad10 into master Nov 8, 2019
@mmalerba mmalerba deleted the google-map-demo branch November 8, 2019 19:21
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@mbehrlich mbehrlich mbehrlich approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Splaktar @mbehrlich @googlebot @mmalerba