Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo(google-map): minor clarity tweaks to the dev-app demo #17647

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@Splaktar
Copy link
Member

Splaktar commented Nov 7, 2019

  • remove infoWindowPosition since it is not actually used
    • and passing in undefined to the Input is a little confusing
    • also it's type doesn't match the position Input's types
  • make the first marker visible on initial load
  • make the first marker clickable to make the demo less confusing
  • use more semantic HTML
@Splaktar Splaktar requested a review from mbehrlich Nov 7, 2019
@googlebot googlebot added the cla: yes label Nov 7, 2019
@Splaktar Splaktar force-pushed the google-map-demo branch from 3f8117d to 6244bfa Nov 8, 2019
- remove infoWindowPosition since it is not actually used
  - and passing in undefined to the @input is a little confusing
  - also it's type doesn't match the position @input's types
- make the first marker visible on initial load
- make the first marker clickable to make the demo less confusing
- use more semantic HTML
@Splaktar Splaktar force-pushed the google-map-demo branch from 6244bfa to 1f638ad Nov 8, 2019
Copy link
Collaborator

mbehrlich left a comment

Thanks!

@mmalerba mmalerba merged commit a5cad10 into master Nov 8, 2019
11 checks passed
11 checks passed
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
@mmalerba mmalerba deleted the google-map-demo branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.