test: disambiguate MDC component test names #17674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: patch
devversion
requested review from
andrewseguin,
crisbeto and
mmalerba
as code owners
googlebot
added
the
cla: yes
Currently the MDC-based component tests are copied from the non-MDC based component. The top-level describe name has not be changed to contain MDC in the most cases. This causes duplicate tests and it's difficult to tell from which component a test failure originates from.
devversion
force-pushed
the
test/better-describe-names-for-mdc-components
branch
from
3ea4459 to
de701b2
Compare
crisbeto
added
pr: lgtm
action: merge
mmalerba
approved these changes
Nov 12, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the MDC-based component tests are copied
from the non-MDC based component. The top-level describe
name has not be changed to contain MDC in the most cases.
This causes duplicate tests and it's difficult to tell
from which component a test failure originates from.