build: Object.assign linting not working #17733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
devversion
requested changes
Nov 17, 2019
A long time ago we decided to ban uses of `Object.assign` because of some issues in g3, but the way we wrote it for the `ban` lint rule meant that it wouldn't be caught. These changes tweak the syntax and fix the cases that are being caught now.
crisbeto
force-pushed
the
object-assign-linting
branch
from
5561fb8 to
d418c9e
Compare
devversion
approved these changes
Nov 18, 2019
devversion
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long time ago we decided to ban uses of
Object.assignbecause of some issues in g3, but the way we wrote it for thebanlint rule meant that it wouldn't be caught. These changes tweak the syntax and fix the cases that are being caught now.