feat(sort): add test harness #17802
Merged
feat(sort): add test harness #17802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
requested review from
andrewseguin,
jelbourn and
a team
as code owners
googlebot
added
the
cla: yes
jelbourn
approved these changes
Nov 25, 2019
| /** Toggles the sort header by clicking on it. Only works if the header is enabled. */ | ||
| async toggle(): Promise<void> { | ||
| return (await this.host()).click(); | ||
| } |
There was a problem hiding this comment.
I wonder here whether toggle is right. To me, toggle means switch between one of two states, but the sort-header potentially has three states. How do you feel about changing this to just click?
There was a problem hiding this comment.
Changed. I called it toggle initially because click doesn't really indicate what will happen when the element is clicked.
crisbeto
force-pushed
the
COMP-198/sort-harness
branch
from
baa1f2e to
64cb858
Compare
Sets up a test harness that covers `MatSort` and `MatSortHeader`.
crisbeto
force-pushed
the
COMP-198/sort-harness
branch
from
64cb858 to
fc6c2e6
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up a test harness that covers
MatSortandMatSortHeader.