Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbuild: remove duplicated tree example code #17844
Conversation
The tree demo app had a bunch of code that was duplicated with examples from `components-examples`. These changes delete that code and use the example components instead.
|
I'm not entirely sure if we have decided on this yet, but my thinking was that we eventually want to have dev-app pages not depend on actual examples? Anyway though. I'm in favor of reducing duplication (mostly because we have no obvious plans for the dev-app yet) |
This comment has been minimized.
This comment has been minimized.
|
I'm pretty sure these were introduced before we had the ability to render examples in the dev app. |
|
LGTM |
jelbourn
merged commit 04d9459
into
angular:master
11 checks passed
11 checks passed
ci/angular: merge status
All checks passed!
cla/google
All necessary CLAs are signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
crisbeto commentedNov 30, 2019
The tree demo app had a bunch of code that was duplicated with examples from
components-examples. These changes delete that code and use the example components instead.