build: remove duplicated tree example code #17844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tree demo app had a bunch of code that was duplicated with examples from `components-examples`. These changes delete that code and use the example components instead.
crisbeto
added
P3
googlebot
added
the
cla: yes
devversion
approved these changes
Dec 2, 2019
There was a problem hiding this comment.
I'm not entirely sure if we have decided on this yet, but my thinking was that we eventually want to have dev-app pages not depend on actual examples?
Anyway though. I'm in favor of reducing duplication (mostly because we have no obvious plans for the dev-app yet)
devversion
added
pr: lgtm
action: merge
|
I'm pretty sure these were introduced before we had the ability to render examples in the dev app. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tree demo app had a bunch of code that was duplicated with examples from
components-examples. These changes delete that code and use the example components instead.