Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove duplicated tree example code #17844

Merged
merged 1 commit into from Dec 2, 2019

Conversation

@crisbeto
Copy link
Member

crisbeto commented Nov 30, 2019

The tree demo app had a bunch of code that was duplicated with examples from components-examples. These changes delete that code and use the example components instead.

The tree demo app had a bunch of code that was duplicated with examples from `components-examples`. These changes delete that code and use the example components instead.
Copy link
Member

devversion left a comment

I'm not entirely sure if we have decided on this yet, but my thinking was that we eventually want to have dev-app pages not depend on actual examples?

Anyway though. I'm in favor of reducing duplication (mostly because we have no obvious plans for the dev-app yet)

@crisbeto

This comment has been minimized.

Copy link
Member Author

crisbeto commented Dec 2, 2019

I'm pretty sure these were introduced before we had the ability to render examples in the dev app.

Copy link
Member

jelbourn left a comment

LGTM

@jelbourn jelbourn merged commit 04d9459 into angular:master Dec 2, 2019
11 checks passed
11 checks passed
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.