Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev-app) Add demo page for FocusTrap #17858

Merged
merged 1 commit into from Dec 4, 2019

Conversation

@vanessanschmitt
Copy link
Collaborator

vanessanschmitt commented Dec 2, 2019

Note that much of this demo page is known to not be working with the
current focus trap implementation (ex. elements in the focus trap with
tabindex > 0 send focus out of the trap, elements in iframes/shadow DOM
get skipped when focus wraps, all focus traps can be escaped by clicking
on the URL and then pressing tab). The demo page will be helpful for
research into FocusTrap improvements (see
#13054).

Screenshot1
Screenshot2

@vanessanschmitt vanessanschmitt requested review from jelbourn, mmalerba and angular/dev-infra-components as code owners Dec 2, 2019
@googlebot googlebot added the cla: yes label Dec 2, 2019
@vanessanschmitt vanessanschmitt force-pushed the vanessanschmitt:focus-trap-demo branch from 7b57341 to 66da82a Dec 2, 2019
src/dev-app/focus-trap/focus-trap-demo.scss Outdated Show resolved Hide resolved
src/dev-app/focus-trap/focus-trap-demo.ts Outdated Show resolved Hide resolved
src/dev-app/focus-trap/focus-trap-demo.ts Outdated Show resolved Hide resolved
src/dev-app/focus-trap/focus-trap-demo.ts Outdated Show resolved Hide resolved
@vanessanschmitt vanessanschmitt force-pushed the vanessanschmitt:focus-trap-demo branch from 66da82a to ef171a5 Dec 3, 2019
Copy link
Member

jelbourn left a comment

LGTM, just a couple of nits for demo CSS classes

src/dev-app/focus-trap/focus-trap-demo.scss Outdated Show resolved Hide resolved
src/dev-app/focus-trap/focus-trap-dialog-demo.scss Outdated Show resolved Hide resolved
@jelbourn

This comment has been minimized.

Copy link
Member

jelbourn commented Dec 3, 2019

(also you can ignore that failing api_golden_checks, it was briefly broken on master due a merge conflict)

@jelbourn

This comment has been minimized.

Copy link
Member

jelbourn commented Dec 3, 2019

Also I just loaded the this locally and this is really good set of demos. I want to turn them into examples for our documentation.

@vanessanschmitt vanessanschmitt force-pushed the vanessanschmitt:focus-trap-demo branch from ef171a5 to 6894a3c Dec 3, 2019
Note that much of this demo page is known to not be working with the
current focus trap implementation (ex. elements in the focus trap with
tabindex > 0 send focus out of the trap, elements in iframes/shadow DOM
get skipped when focus wraps, all focus traps can be escaped by clicking
on the URL and then pressing tab). The demo page will be helpful for
research into FocusTrap improvements (see
#13054).
@vanessanschmitt vanessanschmitt force-pushed the vanessanschmitt:focus-trap-demo branch from 6894a3c to 9f33618 Dec 3, 2019
@vanessanschmitt

This comment has been minimized.

Copy link
Collaborator Author

vanessanschmitt commented Dec 3, 2019

Wow, thanks! Let me know if there's anything I can do to help with that.

@jelbourn jelbourn merged commit 9db1333 into angular:master Dec 4, 2019
11 checks passed
11 checks passed
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.