Skip to content

build: fix CI failures #17867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2019
Merged

build: fix CI failures #17867

merged 1 commit into from
Dec 3, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 3, 2019

Fixes a couple of API goldens failing and the autocomplete demo throwing a strict null compilation error.

@crisbeto
build: fix CI failures
5090c5f 
Fixes a couple of API goldens failing and the autocomplete demo throwing a strict null compilation error.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe target: patch This PR is targeted for the next patch release labels Dec 3, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner December 3, 2019 18:55
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 3, 2019
@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 3, 2019
Splaktar
Splaktar approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jelbourn
jelbourn approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 6ab86ff into angular:master Dec 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

+1 more reviewer

@Splaktar Splaktar Splaktar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @jelbourn @Splaktar @devversion @googlebot