Skip to content

fix(form-field): delete top border from focus animation #17885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2019
Merged

fix(form-field): delete top border from focus animation #17885

merged 1 commit into from
Dec 29, 2019

Conversation

jnavb
Copy link
Contributor

@jnavb jnavb commented Dec 5, 2019

Form field outline top border reduce its opacity during animation when focusing.
According to MDC examples this transition should be instant.

Fixes #17884

@jnavb jnavb requested a review from mmalerba as a code owner December 5, 2019 21:31
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 5, 2019
crisbeto
crisbeto approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Dec 6, 2019
@crisbeto
Copy link
Member

crisbeto commented Dec 6, 2019

Commit message fixup: should say just fix(form-field).

@jnavb
fix(form-field):delete top border from focus animation
7d532d8 
Form field outline top border reduce its opacity during animation when focusing.
According to MDC examples this transition should be instant.

Fixes angular#17884
@jnavb jnavb force-pushed the form-field-outline-animation branch from 17d7c90 to 7d532d8 Compare December 6, 2019 21:42
@jnavb
Copy link
Contributor Author

jnavb commented Dec 6, 2019

Done, thanks.

@crisbeto crisbeto changed the title fix(form-field-outline):delete top border from focus animation fix(form-field): delete top border from focus animation Dec 6, 2019
@crisbeto crisbeto removed the merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed label Dec 6, 2019
@mmalerba mmalerba merged commit 09dc459 into angular:master Dec 29, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

form-field-outline animation differs from MDC
4 participants
@jnavb @crisbeto @googlebot @mmalerba