Skip to content

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Nov 9, 2016

R: @kara

Object.assign isn't available in Google's TS builds.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 9, 2016
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 52e5cb5 into angular:master Nov 9, 2016
@epelc
Copy link
Contributor

epelc commented Nov 9, 2016

@jelbourn What do you think about using polyfills for things like this instead? It would make transitioning over easier if/when google ever gets Object.assign.

@jelbourn
Copy link
Member Author

jelbourn commented Nov 9, 2016

@epelc In this case it was easier to add the function that try to tell Closure Compiler about Object.assign existing

rolandjitsu pushed a commit to rolandjitsu/material2 that referenced this pull request Nov 10, 2016
@jelbourn jelbourn deleted the object-extend branch September 13, 2017 04:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants