Skip to content

Conversation

crisbeto
Copy link
Member

Sets up a test harness for mat-paginator.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe target: minor This PR is targeted for the next minor release labels Dec 15, 2019
@crisbeto crisbeto requested review from andrewseguin, jelbourn and a team as code owners December 15, 2019 08:05
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 15, 2019
@crisbeto crisbeto force-pushed the COMP-200/paginator-harness branch from efc539f to b6cb740 Compare December 17, 2019 22:14
Copy link
Member Author

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've addressed the feedback @jelbourn. Can you take another look?

Sets up a test harness for `mat-paginator`.
@crisbeto crisbeto force-pushed the COMP-200/paginator-harness branch from b6cb740 to 34ddc99 Compare December 17, 2019 22:17
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Dec 18, 2019
@andrewseguin andrewseguin merged commit 5a6cdaf into angular:master Dec 19, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants