Skip to content

docs(readme): fix link to FAQ #17972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2019
Merged

docs(readme): fix link to FAQ #17972

merged 1 commit into from
Dec 16, 2019

Conversation

Splaktar
Copy link
Contributor

It currently renders as [Frequently Asked Questions][./FAQ] with no linking. This fixes that.

Relates to PR #17814.

@Splaktar Splaktar added P2 The issue is important to a large percentage of users, with a workaround docs This issue is related to documentation labels Dec 16, 2019
@Splaktar Splaktar added this to the 9.0.0 milestone Dec 16, 2019
@Splaktar Splaktar requested a review from jelbourn December 16, 2019 05:41
@Splaktar Splaktar requested a review from a team as a code owner December 16, 2019 05:41
@Splaktar Splaktar self-assigned this Dec 16, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 16, 2019
@Splaktar Splaktar mentioned this pull request Dec 16, 2019
Merged
@Splaktar Splaktar added the target: major This PR is targeted for the next major release label Dec 16, 2019
crisbeto
crisbeto approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 16, 2019
josephperrott
josephperrott approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 6ab8e36 into master Dec 16, 2019
@Splaktar Splaktar deleted the fix-faq-link branch December 16, 2019 22:25
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

@josephperrott josephperrott josephperrott approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@Splaktar Splaktar

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Splaktar @crisbeto @devversion @josephperrott @jelbourn @googlebot