build: remove entryComponents from development apps #17999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
pr: merge safe
P4
googlebot
added
the
cla: yes
devversion
approved these changes
Dec 18, 2019
There was a problem hiding this comment.
LGTM (once universal test failure is resolved).
@crisbeto can you also remove entryComponents from the example-module generated file? We don't need it in the docs app anymore.
jelbourn
reviewed
Dec 19, 2019
Since we're running the development apps with Ivy we no longer need to specify `entryComponents`.
crisbeto
force-pushed
the
entry-components-cleanup
branch
from
3aa181c to
ee86c52
Compare
|
I've addressed the feedback @devversion @jelbourn. |
devversion
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're running the development apps with Ivy we no longer need to specify
entryComponents.