Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material-experimental/mdc-form-field): fix baseline and handle custom controls better #18161

Merged
merged 1 commit into from Jan 15, 2020

Conversation

@devversion
Copy link
Member

devversion commented Jan 13, 2020

  • Fixes the baseline of form-field controls and their inputs. Previously
    the baseline was incorrect due to flex alignment and vertical-align misuse.
  • Improves support for custom form-field controls by ensuring that
    spacing applied to MDC inputs, also applies to custom controls.
@devversion

This comment has been minimized.

Copy link
Member Author

devversion commented Jan 13, 2020

Also just related to this: The outline appearance is not working out very nice in our case due to the limitation with the notched-outline. In summary, we need a way to have the outline cover the whole text-field (prefix, suffixes etc), but have the floating label be relative to the infix container.

I'm unsure if MDC will ever support what we need. We need to keep in mind that we don't implement a standard text-field.. but want to support custom form-field controls. I'm playing with the idea of just working around this.. It should help us reduce the overall CSS workarounds too, so it might be worth.

@devversion devversion force-pushed the devversion:wip/form-field-baseline branch from 834d92c to e582182 Jan 13, 2020
…stom controls better

* Fixes the baseline of form-field controls and their inputs. Previously
the baseline was incorrect due to flex alignment.
* Improves support for custom form-field controls by ensuring that
spacing applied to MDC inputs, also applies to custom controls.
   * The same will be needed for the outline appearance, but
   unfortunately we cannot apply any spacing to the infix until we find
   a solution for: material-components/material-components-web#5326
@devversion devversion force-pushed the devversion:wip/form-field-baseline branch from e582182 to 9d9ded0 Jan 13, 2020
Copy link
Member

jelbourn left a comment

LGTM

@andrewseguin andrewseguin merged commit 0c26354 into angular:master Jan 15, 2020
12 checks passed
12 checks passed
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: ngcc_compatibility Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.