Skip to content

fix(material-experimental): mdc-theming and mdc-typography files not published #18251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2020
Merged

fix(material-experimental): mdc-theming and mdc-typography files not published #18251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/material-experimental/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,11 @@ ts_library(
ng_package(
name = "npm_package",
srcs = ["package.json"],
data = MATERIAL_EXPERIMENTAL_SCSS_LIBS,
data = MATERIAL_EXPERIMENTAL_SCSS_LIBS + [
"//src/material-experimental/mdc-helpers",
"//src/material-experimental/mdc-theming",
"//src/material-experimental/mdc-typography",
],
entry_point = ":public-api.ts",
tags = ["release-package"],
deps = MATERIAL_EXPERIMENTAL_TARGETS + MATERIAL_EXPERIMENTAL_TESTING_TARGETS,
Expand Down
1 change: 0 additions & 1 deletion src/material-experimental/config.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ entryPoints = [
"mdc-chips",
"mdc-chips/testing",
"mdc-form-field",
"mdc-helpers",
"mdc-input",
"mdc-list",
"mdc-menu",
Expand Down
14 changes: 3 additions & 11 deletions src/material-experimental/mdc-helpers/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,10 @@
package(default_visibility = ["//visibility:public"])

load("//tools:defaults.bzl", "ng_module", "sass_library")
load("//tools:defaults.bzl", "sass_library")

ng_module(
filegroup(
name = "mdc-helpers",
srcs = glob(
["**/*.ts"],
exclude = ["**/*.spec.ts"],
),
assets = glob(["**/*.html"]),
module_name = "@angular/material-experimental/mdc-helpers",
deps = [
"@npm//@angular/core",
],
srcs = [":mdc_helpers_scss_lib"],
)

# Add all MDC Sass files that we depend on here. After updating MDC dependencies, use the following
Expand Down
9 changes: 0 additions & 9 deletions src/material-experimental/mdc-helpers/index.ts
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions src/material-experimental/mdc-helpers/public-api.ts
View file
Open in desktop

This file was deleted.

8 changes: 8 additions & 0 deletions src/material-experimental/mdc-theming/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@ package(default_visibility = ["//visibility:public"])

load("//tools:defaults.bzl", "sass_binary", "sass_library")

filegroup(
name = "mdc-theming",
srcs = [
":all_themes",
":indigo_pink_prebuilt",
],
)

sass_library(
name = "all_themes",
srcs = [
Expand Down
5 changes: 5 additions & 0 deletions src/material-experimental/mdc-typography/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@ package(default_visibility = ["//visibility:public"])

load("//tools:defaults.bzl", "sass_library")

filegroup(
name = "mdc-typography",
srcs = [":all_typography"],
)

sass_library(
name = "all_typography",
srcs = [
Expand Down