fix(ng-add): do not overwrite version range specified in ng add
#18365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
added
P3
devversion
force-pushed
the
fix/ng-add-respect-ng-add-version-range
branch
from
bbb22f0 to
cc4b354
Compare
The CLI inserts requested dependencies into the `package.json` before `ng add` schematics run. This means that we usually do not need to insert the dependency into `package.json` files. Alternatively, it could happen that the `ng add` schematics run outside of the CLI `ng add` command, or the requested dependency is dev only. In those cases we insert a version based on the current version placeholder.
devversion
changed the title
ng add.ng add
devversion
force-pushed
the
fix/ng-add-respect-ng-add-version-range
branch
from
cc4b354 to
0fa4b01
Compare
Splaktar
approved these changes
Feb 1, 2020
mmalerba
pushed a commit
that referenced
this pull request
Feb 5, 2020
…8365) * fix(ng-add): do not overwrite version range specified in `ng add` The CLI inserts requested dependencies into the `package.json` before `ng add` schematics run. This means that we usually do not need to insert the dependency into `package.json` files. Alternatively, it could happen that the `ng add` schematics run outside of the CLI `ng add` command, or the requested dependency is dev only. In those cases we insert a version based on the current version placeholder. * fixup! fix(ng-add): do not overwrite version range specified in `ng add` Address feedback
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Feb 6, 2020
…gular#18365) * fix(ng-add): do not overwrite version range specified in `ng add` The CLI inserts requested dependencies into the `package.json` before `ng add` schematics run. This means that we usually do not need to insert the dependency into `package.json` files. Alternatively, it could happen that the `ng add` schematics run outside of the CLI `ng add` command, or the requested dependency is dev only. In those cases we insert a version based on the current version placeholder. * fixup! fix(ng-add): do not overwrite version range specified in `ng add` Address feedback
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI inserts requested dependencies into the
package.jsonbeforeng addschematics run. This means that we usually do not need to insertthe dependency into
package.jsonfiles.Alternatively, it could happen that the
ng addschematics run outside ofthe CLI
ng addcommand, or the requested dependency is dev only. In thosecases we insert a version based on the current version placeholder.