Skip to content

docs(theming): removed extra only (angular#35465) #18510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2020
Merged

docs(theming): removed extra only (angular#35465) #18510

merged 1 commit into from
Feb 20, 2020

Conversation

sacgrover
Copy link
Contributor

Fixes #35465

@sacgrover sacgrover requested a review from jelbourn as a code owner February 15, 2020 07:58
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 15, 2020
@sacgrover sacgrover mentioned this pull request Feb 15, 2020
Closed
crisbeto
crisbeto approved these changes Feb 15, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added docs This issue is related to documentation pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Feb 15, 2020
@andrewseguin andrewseguin merged commit 5615979 into angular:master Feb 20, 2020
andrewseguin pushed a commit that referenced this pull request Feb 20, 2020
@sacgrover @andrewseguin
docs(theming): removed extra only (angular#35465) (#18510)
fa7704e 
Fixes #35465

(cherry picked from commit 5615979)
@vikramsubramanian
Copy link

There are still a lot of arguably redundant 'only's in the document. I feel it would be good to remove them.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sacgrover @vikramsubramanian @crisbeto @googlebot @andrewseguin