build: use local bazel installation in test script watch mode #18512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
commented
Feb 15, 2020
crisbeto
force-pushed
the
test-script-local-bazel
branch
from
dda0a5e to
12cdfdb
Compare
|
@devversion I've added the wrapper script as discussed. |
devversion
approved these changes
Feb 16, 2020
crisbeto
force-pushed
the
test-script-local-bazel
branch
from
12cdfdb to
7feef1a
Compare
crisbeto
added
pr: lgtm
action: merge
devversion
approved these changes
Feb 16, 2020
devversion
added
the
target: patch
Currently the test script uses the global Bazel installation in watch mode and the local one in non-watch mode. These changes fix it so we also use the local installation for watch mode.
crisbeto
force-pushed
the
test-script-local-bazel
branch
from
7feef1a to
a2952cf
Compare
andrewseguin
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the test script uses the global Bazel installation in watch mode and the local one in non-watch mode. These changes fix it so we also use the local installation for watch mode.