Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(list): incorrectly selecting items when moving focus using shift + arrow key in single selection mode #18579

Merged
merged 1 commit into from Mar 12, 2020
Merged

fix(list): incorrectly selecting items when moving focus using shift + arrow key in single selection mode #18579

merged 1 commit into from Mar 12, 2020

Conversation

crisbeto
Copy link
Member

The functionality that allows selecting items while moving focus using shift + arrow key is currently always enabled, however it should only apply in multi selection mode.

@crisbeto
fix(list): incorrectly selecting items when moving focus using shift …
7f65924 
…+ arrow key in single selection mode

The functionality that allows selecting items while moving focus using shift + arrow key is currently always enabled, however it should only apply in multi selection mode.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Feb 21, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 21, 2020
jelbourn
jelbourn approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 10, 2020
@andrewseguin andrewseguin merged commit ee3958d into angular:master Mar 12, 2020
andrewseguin pushed a commit that referenced this pull request Mar 12, 2020
@crisbeto @andrewseguin
fix(list): incorrectly selecting items when moving focus using shift …
4a809d7 
…+ arrow key in single selection mode (#18579)

The functionality that allows selecting items while moving focus using shift + arrow key is currently always enabled, however it should only apply in multi selection mode.

(cherry picked from commit ee3958d)
@snyk-bot snyk-bot mentioned this pull request Mar 19, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 28, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 8, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crisbeto @jelbourn @googlebot @andrewseguin