feat: add mixins for density styles of all components #18761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
commented
Mar 9, 2020
devversion
commented
Mar 9, 2020
| // discussion as it would introduce a circular dependency for typography because: | ||
| // -> `all-theme` -> `mat-core` -> `all-typography` -> `all-theme`. | ||
| // This happens because developers rely on the `mat-core` to be available when | ||
| // the `all-theme` file is imported. |
There was a problem hiding this comment.
A possible solution would be that developers need to explicitly import the file that exposes the mat-core mixin. We can also keep it as is for now and import the individual typography mixins.
devversion
force-pushed
the
density-all-mixins
branch
from
126c082 to
cf28dc0
Compare
Similarly to `mdc-density`, we add a mixin for all of the density styles that will exist in `src/material`. Additionally, mdc-typography and mdc-theming mixins are simplified now that the `all-theme` mixins can control individual theming system parts. This does not work for `@angular/material` typography due to a cyclic dependency which we could eliminate if we require people to _explicitly_ import the file where the `mat-core` mixin originates from.
devversion
force-pushed
the
density-all-mixins
branch
from
cf28dc0 to
cb2b3a3
Compare
devversion
added a commit
that referenced
this pull request
Mar 12, 2020
Similarly to `mdc-density`, we add a mixin for all of the density styles that will exist in `src/material`. Additionally, mdc-typography and mdc-theming mixins are simplified now that the `all-theme` mixins can control individual theming system parts. This does not work for `@angular/material` typography due to a cyclic dependency which we could eliminate if we require people to _explicitly_ import the file where the `mat-core` mixin originates from.
devversion
added a commit
that referenced
this pull request
Mar 23, 2020
Similarly to `mdc-density`, we add a mixin for all of the density styles that will exist in `src/material`. Additionally, mdc-typography and mdc-theming mixins are simplified now that the `all-theme` mixins can control individual theming system parts. This does not work for `@angular/material` typography due to a cyclic dependency which we could eliminate if we require people to _explicitly_ import the file where the `mat-core` mixin originates from.
devversion
added a commit
that referenced
this pull request
Mar 31, 2020
Similarly to `mdc-density`, we add a mixin for all of the density styles that will exist in `src/material`. Additionally, mdc-typography and mdc-theming mixins are simplified now that the `all-theme` mixins can control individual theming system parts. This does not work for `@angular/material` typography due to a cyclic dependency which we could eliminate if we require people to _explicitly_ import the file where the `mat-core` mixin originates from.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Mar 31, 2020
Similarly to `mdc-density`, we add a mixin for all of the density styles that will exist in `src/material`. Additionally, mdc-typography and mdc-theming mixins are simplified now that the `all-theme` mixins can control individual theming system parts. This does not work for `@angular/material` typography due to a cyclic dependency which we could eliminate if we require people to _explicitly_ import the file where the `mat-core` mixin originates from.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to
mdc-density, we add a mixin for all of the density stylesthat will exist in
src/material.Additionally, mdc-typography and mdc-theming mixins are simplified
now that the
all-thememixins can control individual theming systemparts. This does not work for
@angular/materialtypography due toa cyclic dependency which we could eliminate if we require people
to explicitly import the file where the
mat-coremixin originates from.