Skip to content

fix(tabs): tab nav bar not disabling pagination animation #18886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2020
Merged

fix(tabs): tab nav bar not disabling pagination animation #18886

merged 1 commit into from
Apr 7, 2020

Conversation

crisbeto
Copy link
Member

Fixes the pagination animation not being disabled when using the NoopAnimationsModule.

@crisbeto
fix(tabs): tab nav bar not disabling pagination animation
5f57435 
Fixes the pagination animation not being disabled when using the `NoopAnimationsModule`.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Mar 22, 2020
@crisbeto crisbeto requested a review from andrewseguin as a code owner March 22, 2020 18:26
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 22, 2020
jelbourn
jelbourn approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 24, 2020
@mmalerba mmalerba merged commit 973ee82 into angular:master Apr 7, 2020
mmalerba pushed a commit that referenced this pull request Apr 14, 2020
@crisbeto @mmalerba
fix(tabs): tab nav bar not disabling pagination animation (#18886)
a6e5423 
Fixes the pagination animation not being disabled when using the `NoopAnimationsModule`.
This was referenced May 3, 2020
Merged
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @mmalerba