build: include mdc-color and mdc-density entry-points in release #19141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new `mdc-color` and `mdc-density` entry-points should be included in the `@angular/material-experimental` package.
devversion
added
P2
googlebot
added
the
cla: yes
devversion
added a commit
to devversion/material2
that referenced
this pull request
May 14, 2020
As of the new theming API refactorings, a theme by default includes density styles for the zero density-scale. This means that the common pattern of using the `angular-material-theme` for secondary themes in a project could cause duplicated styles when the new API is explicitly used. Generally, we want to detect if theme styles are duplicated. This will be helpful for developers defining multiple themes as we can notify them if similar theme styles end up multiple times in an application. If the duplicate styles are intentional, the warning can be explicitly disabled. docs: improvements to guide changes docs: add description for individual theme mixins refactor: add duplicated theme styles check to all individual theme mixins Adds the duplicated theme styles check to all individual theme mixins. Also, adds a lint rule that enforces that the theme styles check is included in every theme mixin w/ autofix. build: do not build test sass files in legacy output Looks like the exclude glob does not work as expected. Hence the new theming bundle test fails as there is no theming bundle when the legacy gulp tasks process Sass files. Address feedback as per team meeting Address feedback (cleanup stylelint rule) More obvious error if theme variables are named incorrectly Also ran clang-format refactor: all-theme file should transitively provide `mat-core` mixin. Partially reverts commit 9c97cf3 so that we don't need to perform a large migration in g3 to land the density API changes. refactor: convert new theme-mixin-api stylelint rule to typescript We recently refactored all stylelint rules to TypeScript. Similarly we should migrate the new rule that has been added in the density feature branch. build: include mdc-color and mdc-density entry-points in release (angular#19141) The new `mdc-color` and `mdc-density` entry-points should be included in the `@angular/material-experimental` package.
andrewseguin
pushed a commit
that referenced
this pull request
May 14, 2020
As of the new theming API refactorings, a theme by default includes density styles for the zero density-scale. This means that the common pattern of using the `angular-material-theme` for secondary themes in a project could cause duplicated styles when the new API is explicitly used. Generally, we want to detect if theme styles are duplicated. This will be helpful for developers defining multiple themes as we can notify them if similar theme styles end up multiple times in an application. If the duplicate styles are intentional, the warning can be explicitly disabled. docs: improvements to guide changes docs: add description for individual theme mixins refactor: add duplicated theme styles check to all individual theme mixins Adds the duplicated theme styles check to all individual theme mixins. Also, adds a lint rule that enforces that the theme styles check is included in every theme mixin w/ autofix. build: do not build test sass files in legacy output Looks like the exclude glob does not work as expected. Hence the new theming bundle test fails as there is no theming bundle when the legacy gulp tasks process Sass files. Address feedback as per team meeting Address feedback (cleanup stylelint rule) More obvious error if theme variables are named incorrectly Also ran clang-format refactor: all-theme file should transitively provide `mat-core` mixin. Partially reverts commit 9c97cf3 so that we don't need to perform a large migration in g3 to land the density API changes. refactor: convert new theme-mixin-api stylelint rule to typescript We recently refactored all stylelint rules to TypeScript. Similarly we should migrate the new rule that has been added in the density feature branch. build: include mdc-color and mdc-density entry-points in release (#19141) The new `mdc-color` and `mdc-density` entry-points should be included in the `@angular/material-experimental` package.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
mdc-colorandmdc-densityentry-points should beincluded in the
@angular/material-experimentalpackage.