Skip to content

refactor(google-maps): use assert functions to avoid casting to non-nullable value #19178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2020
Merged

refactor(google-maps): use assert functions to avoid casting to non-nullable value #19178

merged 1 commit into from
May 8, 2020

Conversation

crisbeto
Copy link
Member

We can take advantage of TypeScript's asserts keyword so that we don't have to cast values to be non-nullable, when we've already asserted that they exist.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Apr 26, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 26, 2020
@crisbeto
refactor(google-maps): use assert functions to avoid casting to non-n…
b7157f7 
…ullable value

We can take advantage of TypeScript's `asserts` keyword so that we don't have to cast values to be non-nullable, when we've already asserted that they exist.
@crisbeto crisbeto force-pushed the google-maps-asserts branch from c90fa1a to b7157f7 Compare April 26, 2020 12:54
jelbourn
jelbourn approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is really cool, I somehow missed this feature when it came out

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Apr 28, 2020
@mbehrlich
Copy link
Collaborator

LGTM

Great idea, I hate using non-null assertions.

@crisbeto crisbeto mentioned this pull request May 2, 2020
Merged
@jelbourn jelbourn added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels May 8, 2020
@jelbourn
Copy link
Member

jelbourn commented May 8, 2020

Changed to major since there's a merge conflict with the patch branch

@jelbourn jelbourn merged commit dfe92fc into angular:master May 8, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

@mbehrlich mbehrlich

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @mbehrlich @jelbourn @googlebot