build: add script for approving public API changes #19231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
devversion
approved these changes
May 2, 2020
|
Fantastic idea. What would you think of making it |
|
I'm not attached to the name. I chose it so it's consistent with the |
The Bazel targets for approving public API changes are a little convoluted and hard to remember. These changes add a small script to make it easier to manage. E.g. `yarn api:approve material/chips`.
crisbeto
force-pushed
the
api-golden-script
branch
from
e2cd964 to
d37699b
Compare
jelbourn
pushed a commit
that referenced
this pull request
May 7, 2020
The Bazel targets for approving public API changes are a little convoluted and hard to remember. These changes add a small script to make it easier to manage. E.g. `yarn api:approve material/chips`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bazel targets for approving public API changes are a little convoluted and hard to remember. These changes add a small script to make it easier to manage. E.g.
yarn api:approve material/chips.