Skip to content

refactor(button-toggle): remove deprecated APIs for version 10 #19289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 8, 2020

Removes the button-toggle APIs that were deprecated back in 8, but were never removed.

BREAKING CHANGES:

  • MatButtonToggleGroupMultiple has been removed. Use MatButtonToggleGroup instead.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels May 8, 2020
@crisbeto crisbeto requested a review from jelbourn as a code owner May 8, 2020 10:59
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 8, 2020
@crisbeto crisbeto force-pushed the button-toggle-v10-breaking-changes branch from a0f3649 to ea00c9e Compare May 8, 2020 11:54
Removes the `button-toggle` APIs that were deprecated back in 8, but were never removed.

BREAKING CHANGES:
* `MatButtonToggleGroupMultiple` has been removed. Use `MatButtonToggleGroup` instead.
@crisbeto crisbeto force-pushed the button-toggle-v10-breaking-changes branch from ea00c9e to f99f5bf Compare May 11, 2020 14:55
@crisbeto
Copy link
Member Author

I've addressed the feedback.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 11, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 45435c9 into angular:master May 26, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants