Skip to content

Fix selector in expansion-expand-collapse-all #19499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2020
Merged

Fix selector in expansion-expand-collapse-all #19499

merged 1 commit into from
Jun 5, 2020

Conversation

rnlee0054
Copy link
Contributor

No description provided.

@rnlee0054 rnlee0054 requested a review from jelbourn as a code owner June 1, 2020 18:38
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 1, 2020
devversion
devversion approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. Thanks!

@devversion devversion added merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 1, 2020
@rnlee0054
Copy link
Contributor Author

Thanks! Also unsure if this is managed from this repo, but the stackblitz linked from the docs for this component also has the same issue in the selector. https://stackblitz.com/angular/kkljebborvv?file=src%2Fapp%2Fexpansion-expand-collapse-all-example.ts

@devversion
Copy link
Member

The StackBlitz from the docs is based on the component code you just changed. So, this PR should fix the example in the docs StackBlitz. Thanks!

@jelbourn jelbourn added merge safe P4 A relatively minor issue that is not relevant to core functions docs This issue is related to documentation labels Jun 4, 2020
@jelbourn jelbourn merged commit 31afc80 into angular:master Jun 5, 2020
jelbourn pushed a commit that referenced this pull request Jun 5, 2020
@rnlee0054 @jelbourn
docs(material/expansion): Fix expansion-expand-collapse-all-example s…
6261d6a 
…elector (#19499)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rnlee0054 @devversion @jelbourn @googlebot