CdkListbox file skeleton #19612

nielsr98 · 2020-06-11T19:39:24Z

Created directory for listbox in cdk-experimental and created empty files that will eventually contain the listbox and listbox option directives.

devversion · 2020-06-11T19:46:25Z

src/cdk-experimental/listbox/BUILD.bazel

+        "//src/cdk/portal",
+        "@npm//@angular/animations",
+        "@npm//@angular/core",
+        "@npm//rxjs",


I'm not sure if this file has been built up from an existing prototype you already have, but generally I'd prefer us adding these dependencies on-demand. Otherwise we might end up with unused dependencies that slow-down CI and local development (same for the loaded, but unused rules above)

Ah okay that makes sense. Yeah I'll just remove it and then add them as needed.

jelbourn · 2020-06-12T02:58:01Z

On the file names: we typically don't suffix file names with -directive, so I would just do listbox.ts and option.ts. I would also just add an empty export class CdkListbox { } (and option) along with a build rule for the package to confirm that everything compiles as expected

jelbourn

LGTM

jelbourn · 2020-06-12T16:42:44Z

.github/CODEOWNERS

@@ -127,6 +127,7 @@
 /src/cdk-experimental/dialog/**                    @jelbourn @crisbeto
 /src/cdk-experimental/popover-edit/**              @kseamon @andrewseguin
 /src/cdk-experimental/scrolling/**                 @mmalerba
+/src/cdk-experimental/listbox/**                   @nielsr98


You can add me here also

jelbourn · 2020-06-12T16:43:40Z

src/cdk-experimental/listbox/listbox.ts

+    exportAs: 'cdkListbox',
+    host: {
+        role: 'listbox',
+        tabindex: '0'


I would leave off the tabindex and deal with focus management in a follow-up PR focused just on dealing with focus/activedescendant

andrewseguin · 2020-06-12T17:16:01Z

Can you rebase the change

googlebot · 2020-06-14T22:41:42Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot · 2020-06-15T15:27:26Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

jelbourn · 2020-06-15T16:06:18Z

This is rebased and ready to go

rafaelss95 · 2020-06-17T01:05:33Z

src/cdk-experimental/listbox/listbox-module.ts

+
+const EXPORTED_DECLARATIONS = [CdkListbox, CdkOption];
+@NgModule({
+    exports: EXPORTED_DECLARATIONS,


Excuse me but it looks like it's indented by 4, not 2 (here and listbox.ts).

Fixed, thanks.

…iles.

…stbox to cdk-experimental entry points.

… public-api.

…iles.

* build: created listbox directory and BUILD.bazel file. * build: filled BUILD.bazel file. * build: Added required files to listbox directory. * build: added listbox option directive and renamed listbox directive files. * fix: Removed currently unused dependencies from BUILD.bazel. Added listbox to cdk-experimental entry points. * Removed BUILD.bazel for temp test * fix: filled out BUILD.bazel and other required listbox files. * fix: changed double quote to single quote and added listbox module to public-api. * fix: semicolon. * removed tabindex from listbox host and changed option directive name. * build: Added required files to listbox directory. * build: added listbox option directive and renamed listbox directive files. * fix: filled out BUILD.bazel and other required listbox files. * build: Added required files to listbox directory. * build: added listbox option directive and renamed listbox directive files. * build: Added required files to listbox directory. * build: added listbox option directive and renamed listbox directive files. * fix: reduced indent size from 4 to 2. * fix: chore, removed empty files that appeared after rebase. * fix: added back menu to config.bzl

angular-automatic-lock-bot · 2020-07-18T00:06:55Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 11, 2020

nielsr98 requested review from jelbourn and scriby June 11, 2020 19:39

devversion approved these changes Jun 11, 2020

View reviewed changes

nielsr98 requested a review from a team as a code owner June 12, 2020 04:11

jelbourn approved these changes Jun 12, 2020

View reviewed changes

jelbourn added merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 12, 2020

andrewseguin added the needs rebase label Jun 12, 2020

scriby approved these changes Jun 13, 2020

View reviewed changes

nielsr98 requested review from crisbeto and mmalerba as code owners June 14, 2020 22:41

googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Jun 14, 2020

nielsr98 force-pushed the cdk-listbox branch from e53598a to 55ef17c Compare June 15, 2020 15:27

googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Jun 15, 2020

jelbourn removed the needs rebase label Jun 15, 2020

rafaelss95 reviewed Jun 17, 2020

View reviewed changes

nielsr98 added 3 commits June 16, 2020 21:11

build: created listbox directory and BUILD.bazel file.

1166e34

build: filled BUILD.bazel file.

bb9a145

build: Added required files to listbox directory.

067d25d

nielsr98 added 17 commits June 16, 2020 21:11

build: added listbox option directive and renamed listbox directive f…

f35696b

…iles.

fix: Removed currently unused dependencies from BUILD.bazel. Added li…

76ea456

…stbox to cdk-experimental entry points.

Removed BUILD.bazel for temp test

5f35968

fix: filled out BUILD.bazel and other required listbox files.

3bf2b9f

fix: changed double quote to single quote and added listbox module to…

58d21bf

… public-api.

fix: semicolon.

f2a4d8b

removed tabindex from listbox host and changed option directive name.

6d5cdbd

build: Added required files to listbox directory.

99a05ee

build: added listbox option directive and renamed listbox directive f…

0cda751

…iles.

fix: filled out BUILD.bazel and other required listbox files.

b7b8de8

build: Added required files to listbox directory.

5ff0284

build: added listbox option directive and renamed listbox directive f…

4f4413c

…iles.

build: Added required files to listbox directory.

30705be

build: added listbox option directive and renamed listbox directive f…

73e95b8

…iles.

fix: reduced indent size from 4 to 2.

dc78b5b

fix: chore, removed empty files that appeared after rebase.

b92e7c6

fix: added back menu to config.bzl

189215d

nielsr98 force-pushed the cdk-listbox branch from 55ef17c to 189215d Compare June 17, 2020 01:28

nielsr98 added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 17, 2020

mmalerba merged commit 0428231 into angular:master Jun 17, 2020

angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CdkListbox file skeleton #19612

CdkListbox file skeleton #19612

Uh oh!

nielsr98 commented Jun 11, 2020

Uh oh!

devversion Jun 11, 2020

Uh oh!

nielsr98 Jun 11, 2020

Uh oh!

jelbourn commented Jun 12, 2020

Uh oh!

jelbourn left a comment

Uh oh!

jelbourn Jun 12, 2020

Uh oh!

jelbourn Jun 12, 2020

Uh oh!

andrewseguin commented Jun 12, 2020

Uh oh!

googlebot commented Jun 14, 2020

Uh oh!

googlebot commented Jun 15, 2020

Uh oh!

jelbourn commented Jun 15, 2020

Uh oh!

rafaelss95 Jun 17, 2020

Uh oh!

nielsr98 Jun 17, 2020

Uh oh!

angular-automatic-lock-bot bot commented Jul 18, 2020

Uh oh!

Uh oh!

CdkListbox file skeleton #19612

CdkListbox file skeleton #19612

Uh oh!

Conversation

nielsr98 commented Jun 11, 2020

Uh oh!

devversion Jun 11, 2020

Choose a reason for hiding this comment

Uh oh!

nielsr98 Jun 11, 2020

Choose a reason for hiding this comment

Uh oh!

jelbourn commented Jun 12, 2020

Uh oh!

jelbourn left a comment

Choose a reason for hiding this comment

Uh oh!

jelbourn Jun 12, 2020

Choose a reason for hiding this comment

Uh oh!

jelbourn Jun 12, 2020

Choose a reason for hiding this comment

Uh oh!

andrewseguin commented Jun 12, 2020

Uh oh!

googlebot commented Jun 14, 2020

Uh oh!

googlebot commented Jun 15, 2020

Uh oh!

jelbourn commented Jun 15, 2020

Uh oh!

rafaelss95 Jun 17, 2020

Choose a reason for hiding this comment

Uh oh!

nielsr98 Jun 17, 2020

Choose a reason for hiding this comment

Uh oh!

angular-automatic-lock-bot bot commented Jul 18, 2020

Uh oh!

Uh oh!