build: improve postinstall patches with better messaging and prompt #19615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
merge safe
target: patch
googlebot
added
the
cla: yes
|
I wish we'd use TypeScript for this, but it's probably not worth the effort, and the postinstall patches should be somewhat fast. Here is a link to review this PR with whitespace ignored: https://github.com/angular/components/pull/19615/files?w=1 |
Sometimes we need to change existing postinstall patches. This requires a cleanup of the currently installed node modules, but there is no good warning/messaging. We improve this with this commit by detecting such stale patches and prompting for automatic retry with cleaned up node modulesbuild: option to automatically retry postinstall patches Sometimes we need to change existing postinstall patches. This requires a cleanup of the currently installed node modules, but there is no good warning/messaging. We improve this with this commit by detecting such stale patches and prompting for automatic retry with cleaned up node modules. Note: Please clean up your node modules after this change. This needs to still happen manually once, so that we can keep track of applied patch versions and report/prompt automatically in the future.
devversion
force-pushed
the
build/postinstall-auto-cleanup
branch
from
fd45213 to
638af9c
Compare
andrewseguin
pushed a commit
that referenced
this pull request
Jun 12, 2020
Sometimes we need to change existing postinstall patches. This requires a cleanup of the currently installed node modules, but there is no good warning/messaging. We improve this with this commit by detecting such stale patches and prompting for automatic retry with cleaned up node modulesbuild: option to automatically retry postinstall patches Sometimes we need to change existing postinstall patches. This requires a cleanup of the currently installed node modules, but there is no good warning/messaging. We improve this with this commit by detecting such stale patches and prompting for automatic retry with cleaned up node modules. Note: Please clean up your node modules after this change. This needs to still happen manually once, so that we can keep track of applied patch versions and report/prompt automatically in the future.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we need to change existing postinstall patches. This
requires a cleanup of the currently installed node modules, but
there is no good warning/messaging. We improve this with this
commit by detecting such stale patches and prompting for
automatic retry with cleaned up node modulesbuild: option to
automatically retry postinstall patches
Sometimes we need to change existing postinstall patches. This
requires a cleanup of the currently installed node modules, but
there is no good warning/messaging. We improve this with this
commit by detecting such stale patches and prompting for automatic
retry with cleaned up node modules.
Note: Please clean up your node modules after this change. This needs to
still happen manually once, so that we can keep track of applied
patch versions and report/prompt automatically in the future.