Skip to content

feat(card/testing): Add a test harness for MatCard #19833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 10, 2020
Merged

feat(card/testing): Add a test harness for MatCard #19833

merged 6 commits into from
Jul 10, 2020

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Jul 1, 2020

No description provided.

@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround merge safe target: patch This PR is targeted for the next patch release labels Jul 1, 2020
@mmalerba mmalerba requested review from jelbourn and annieyw July 1, 2020 20:01
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 1, 2020
jelbourn
jelbourn reviewed Jul 2, 2020
View reviewed changes
@mmalerba mmalerba requested a review from devversion as a code owner July 6, 2020 18:59
@mmalerba mmalerba requested a review from a team as a code owner July 9, 2020 19:21
@mmalerba mmalerba added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jul 9, 2020
@mmalerba
Copy link
Contributor Author

mmalerba commented Jul 9, 2020

should be good to go now, PTAL

devversion
devversion approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like you need to setup the entry-point in config.bzl and also rebase for the integration tests failures to go away.

@mmalerba mmalerba added lgtm action: merge The PR is ready for merge by the caretaker labels Jul 9, 2020
@mmalerba mmalerba merged commit 54c2d16 into angular:master Jul 10, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn left review comments

@devversion devversion devversion approved these changes

@annieyw annieyw Awaiting requested review from annieyw

Assignees

@jelbourn jelbourn

@annieyw annieyw

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmalerba @jelbourn @devversion @googlebot @annieyw