fix(menu): throw error if menu contains its own trigger #19943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
|
Excellent!!! |
|
OMG that was fast!! Thank you so much @crisbeto !!!! |
crisbeto
force-pushed
the
19941/recursive-menu-error
branch
from
c44e86c to
877c02e
Compare
|
I've addressed the feedback. I added a dev mode check around the other assertions as well. |
If the consumer puts a trigger inside a menu and passes the menu back to the trigger, we'll go into an infinite loop and throw a cryptic error message. These changes detect such a case and throw a better error. Example of a case that will be flagged: ``` <mat-menu #menu="matMenu"> <button [matMenuTriggerFor]="menu"></button> </mat-menu> ``` Fixes angular#19941.
crisbeto
force-pushed
the
19941/recursive-menu-error
branch
from
877c02e to
a0b483b
Compare
wagnermaciel
pushed a commit
that referenced
this pull request
Jul 24, 2020
If the consumer puts a trigger inside a menu and passes the menu back to the trigger, we'll go into an infinite loop and throw a cryptic error message. These changes detect such a case and throw a better error. Example of a case that will be flagged: ``` <mat-menu #menu="matMenu"> <button [matMenuTriggerFor]="menu"></button> </mat-menu> ``` Fixes #19941. (cherry picked from commit 1b7ba0b)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the consumer puts a trigger inside a menu and passes the menu back to the trigger, we'll go into an infinite loop and throw a cryptic error message. These changes detect such a case and throw a better error. Example of a case that will be flagged:
Fixes #19941.