fix(select): indicating programmatic value change as user interaction in some cases #19970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in some cases We were using `ListKeyManager.setActiveItem` to change the active item when a value is assigned through a `FormControl`, in order to have it be highlighted if the user opens the panel. The problem is that `setActiveItem` emits a change event as if it's coming from the user, causing us to dispatch an event object with `isUserInput: true`. These changes use `updateActiveItem` instead which only updates the item, but doesn't emit any events. Fixes angular#19967.
crisbeto
added
P3
googlebot
added
the
cla: yes
wagnermaciel
pushed a commit
that referenced
this pull request
Jul 24, 2020
… in some cases (#19970) We were using `ListKeyManager.setActiveItem` to change the active item when a value is assigned through a `FormControl`, in order to have it be highlighted if the user opens the panel. The problem is that `setActiveItem` emits a change event as if it's coming from the user, causing us to dispatch an event object with `isUserInput: true`. These changes use `updateActiveItem` instead which only updates the item, but doesn't emit any events. Fixes #19967. (cherry picked from commit 316141f)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using
ListKeyManager.setActiveItemto change the active item when a value is assigned through aFormControl, in order to have it be highlighted if the user opens the panel. The problem is thatsetActiveItememits a change event as if it's coming from the user, causing us to dispatch an event object withisUserInput: true.These changes use
updateActiveIteminstead which only updates the item, but doesn't emit any events.Fixes #19967.