fix(input): changed after checked error if input has static placeholder #20015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The placeholder attribute is set based on a child query which is prone to "changed after checked" errors. These changes switch to assigning it ourselves directly to the DOM manually.
crisbeto
added
P2
googlebot
added
the
cla: yes
andrewseguin
added
lgtm
action: merge
andrewseguin
approved these changes
Jul 16, 2020
andrewseguin
added
target: minor
ngwattcos
pushed a commit
to ngwattcos/components
that referenced
this pull request
Jul 20, 2020
…er (angular#20015) The placeholder attribute is set based on a child query which is prone to "changed after checked" errors. These changes switch to assigning it ourselves directly to the DOM manually.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The placeholder attribute is set based on a child query which is prone to "changed after checked" errors. These changes switch to assigning it ourselves directly to the DOM manually.