Skip to content

chore: clean up unnecessary providers arrays from existing code #20191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2020
Merged

chore: clean up unnecessary providers arrays from existing code #20191

merged 1 commit into from
Aug 5, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 4, 2020

Passing in providers: [] isn't necessary so these changes clean up the existing code.

@crisbeto
chore: clean up unnecessary providers arrays from existing code
293971a 
Passing in `providers: []` isn't necessary so these changes clean up the existing code.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Aug 4, 2020
@crisbeto crisbeto requested review from jelbourn and a team as code owners August 4, 2020 19:31
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 4, 2020
josephperrott
josephperrott approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 4, 2020
jelbourn
jelbourn approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LgTM

@mmalerba mmalerba merged commit abce69b into angular:master Aug 5, 2020
mmalerba pushed a commit that referenced this pull request Aug 5, 2020
@crisbeto @mmalerba
chore: clean up unnecessary providers arrays from existing code (#20191)
3d8597f 
Passing in `providers: []` isn't necessary so these changes clean up the existing code.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees

@wagnermaciel wagnermaciel

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@crisbeto @jelbourn @devversion @josephperrott @googlebot @mmalerba @wagnermaciel