fix(material/progress-spinner): progress-spinners with diameter less than or equal to 10 #20193
Conversation
…than or equal to 10 do not show Fixes a bug in the Angular Material ‘progress-spinner’ component where progress-spinners with a diameter less than or equal to 10 do not show. This is because the spinner radius calculation is based on subtracting a constant stroke width of 10 from the diameter, resulting in a radius of 0 or less for small diameters. For these cases a fraction of the diameter can be subtracted instead of the constant stroke width. Fixes angular#19469
googlebot
added
the
cla: yes
| return (this.diameter - BASE_STROKE_WIDTH) / 2; | ||
| // In the general case adjust the diameter by the base stroke width. | ||
| // For small diameters adjust by a diameter percentage so that the radius is greater than 0. | ||
| return Math.max(this.diameter - BASE_STROKE_WIDTH, this.diameter * 0.09) / 2; |
There was a problem hiding this comment.
The smallest currently supported diameter is 11, which gives a circle radius of ½ or approximately (0.09*11)/2. So for diameters <= 10 I maintain the same circle radius ratio by using (0.09 * diameter)/2, instead of subtracting a BASE_STROKE_WIDTH of 10.
andrewseguin
removed
the
cla: yes
|
@AlexLangdon Sorry this review took so long - this change looks okay to me. Would you like to rebase and we can see about getting it landed? |
andrewseguin
added
target: patch
|
Closing due to inactivity - sorry that we didn't get a chance to finish this when sent. Feel free to reopen a rebased PR if you'd still like to land this |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
As @paulferaud pointed out in #19469, using
BASE_STROKE_WIDTHwhen calculating the spinner circle radius is causing issues, such as the progress spinner becoming invisible if the diameter is less than or equal to 10.One solution is to change the radius calculation for diameters less than 11 and subtract a fraction of the diameter instead of
BASE_STROKE_WIDTH.This also maintains the current behaviour for any diameters above 10, so shouldn’t cause breaking screenshot tests.
Fixes #19469