Skip to content

Conversation

rafaelss95
Copy link
Contributor

After #20165 the CI:lint started to fail due to these leftover usages.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 19, 2020
@rafaelss95 rafaelss95 changed the title refactor: replace missing asObservable usages refactor: remove missing asObservable usages Aug 19, 2020
@rafaelss95 rafaelss95 force-pushed the refactor/as-observable branch from e7fc36a to 9944e66 Compare August 19, 2020 04:16
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Aug 19, 2020
@crisbeto crisbeto added the P2 The issue is important to a large percentage of users, with a workaround label Aug 19, 2020
@wagnermaciel wagnermaciel added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Aug 19, 2020
@wagnermaciel
Copy link
Contributor

Switching to target minor since this has merge conflicts with 10.1.x

@wagnermaciel wagnermaciel merged commit 578d4ef into angular:master Aug 19, 2020
@rafaelss95 rafaelss95 deleted the refactor/as-observable branch August 19, 2020 16:08
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants