refactor(material/list): fix action list CSS styles conflict with MDC-based list #20477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
P3
devversion
requested review from
crisbeto,
jelbourn and
mmalerba
as code owners
googlebot
added
the
cla: yes
devversion
added
P2
…-based list The Angular Material action list has been styled using an element selector, instead of using the corresponding CSS class. This meant that the MDC-based list seemed to have a working action list, but in reality it was just working due to the leaked styles from the non-MDC list. This fixes the selector in the Angular Material list, and adds the necessary styles for the action list to the MDC list styles.
devversion
force-pushed
the
fix/mdc-list-button-reset-action-list
branch
from
7297fde to
6fd5034
Compare
andrewseguin
removed
the
cla: yes
googlebot
added
the
cla: yes
|
Closing in favor of #24186 which is more recent and likely to be merged 😄 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Angular Material action list has been styled using an element selector,
instead of using the corresponding CSS class. This meant that the MDC-based
list seemed to have a working action list, but in reality it was just working due
to the leaked styles from the non-MDC list.
This fixes the selector in the Angular Material list, and adds the necessary styles
for the action list to the MDC list styles.
Note: I used the
refactortype as I wasn't sure whether we want this to show up for the non-MDC list in the changelog.