Skip to content

fix(material/form-field): dynamic hint end alignment not working #20657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2020
Merged

fix(material/form-field): dynamic hint end alignment not working #20657

merged 1 commit into from
Oct 7, 2020

Conversation

crisbeto
Copy link
Member

Binding to the align property of mat-hint didn't work, because while we were adding a class, the class wasn't being used. Using a static value works by accident.

Fixes #20629.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Sep 25, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 25, 2020
@crisbeto
fix(material/form-field): dynamic hint end alignment not working
f70abca 
Binding to the `align` property of `mat-hint` didn't work, because while we were adding
a class, the class wasn't being used. Using a static value works by accident.

Fixes angular#20629.
@crisbeto crisbeto force-pushed the 20629/hint-alignment branch from 4974751 to f70abca Compare September 30, 2020 08:24
mmalerba
mmalerba approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Sep 30, 2020
@wagnermaciel wagnermaciel merged commit a087edd into angular:master Oct 7, 2020
wagnermaciel pushed a commit that referenced this pull request Oct 7, 2020
@crisbeto @wagnermaciel
fix(material/form-field): dynamic hint end alignment not working (#20657
95cc020 
)

Binding to the `align` property of `mat-hint` didn't work, because while we were adding
a class, the class wasn't being used. Using a static value works by accident.

Fixes #20629.

(cherry picked from commit a087edd)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mat-hint is not aligned
4 participants
@crisbeto @mmalerba @googlebot @wagnermaciel