Skip to content

feat(cdk/table): add API for registering no data row #20658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 25, 2020

We have APIs that allow for rows and cells to be registered programmatically for cases where they aren't descendants of the table, but we didn't have something similar for the "no data" row. These changes add a method and update the examples.

Fixes #20560.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Sep 25, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 25, 2020
@jelbourn jelbourn added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Sep 28, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I would consider this a feat

@crisbeto crisbeto changed the title fix(cdk/table): add API for registering no data row feat(cdk/table): add API for registering no data row Sep 29, 2020
@crisbeto crisbeto force-pushed the 20560/no-data-row-api branch from d5eb123 to a423f4d Compare September 29, 2020 05:55
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 29, 2020
We have APIs that allow for rows and cells to be registered programmatically for cases
where they aren't descendants of the table, but we didn't have something similar for
the "no data" row. These changes add a method and update the examples.

Fixes angular#20560.
@crisbeto crisbeto force-pushed the 20560/no-data-row-api branch from a423f4d to 75ff976 Compare September 30, 2020 08:25
@mmalerba mmalerba merged commit 58341a7 into angular:master Oct 2, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(table): matNoDataRow directive doesn't work when wrapped by another table
4 participants