fix(material/list): emit selectionChange event when selecting with ctrl + a #20667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
requested review from
devversion,
jelbourn and
mmalerba
as code owners
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
15696/selection-list-change-event
branch
from
025328e to
303aa9f
Compare
crisbeto
commented
Sep 28, 2020
| */ | ||
| public option: MatListOption, | ||
| /** Reference to the options that have been changed. */ | ||
| public options: MatListOption[]) {} |
There was a problem hiding this comment.
If we wanted to avoid this future breaking change, we could also emit one event per selected option like we do in mat-select. I decided not to do it, because the mat-select behavior feels broken.
…rl + a Fixes that we weren't emitting the `selectionChange` event when the user toggles all options with the ctrl + a shortcut. Also replaces `MatSelectionListChange.option` with `options` which is an array of all options that were changed by the current event. Fixes angular#15696.
crisbeto
force-pushed
the
15696/selection-list-change-event
branch
from
303aa9f to
7df08e5
Compare
wagnermaciel
pushed a commit
that referenced
this pull request
Oct 7, 2020
…rl + a (#20667) Fixes that we weren't emitting the `selectionChange` event when the user toggles all options with the ctrl + a shortcut. Also replaces `MatSelectionListChange.option` with `options` which is an array of all options that were changed by the current event. Fixes #15696. (cherry picked from commit 628b5e9)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that we weren't emitting the
selectionChangeevent when the user toggles all options with the ctrl + a shortcut. Also replacesMatSelectionListChange.optionwithoptionswhich is an array of all options that were changed by the current event.Fixes #15696.