build: stylelint not working correctly

[crisbeto]

Recently we changed the names of some Stylelint rules, but the linter wasn't updated which leads to several warnings for each file that goes through it.

For reference, Stylelint logs the following on the CI as well, but we didn't notice because it exits with a non-error code.

src/material/core/theming/tests/test-theming-api.scss
 1:1  ×  Unknown rule function-url-scheme-disallowed-list         function-url-scheme-disallowed-list
 1:1  ×  Unknown rule unit-allowed-list                           unit-allowed-list
 1:1  ×  Unknown rule declaration-property-value-disallowed-list  declaration-property-value-disallowed-list

src/material/core/theming/tests/test-theming-bundle.scss
 1:1  ×  Unknown rule function-url-scheme-disallowed-list         function-url-scheme-disallowed-list
 1:1  ×  Unknown rule unit-allowed-list                           unit-allowed-list
 1:1  ×  Unknown rule declaration-property-value-disallowed-list  declaration-property-value-disallowed-list

src/cdk/schematics/ng-update/test-cases/misc/global-stylesheets-test.scss
 1:1  ×  Unknown rule function-url-scheme-disallowed-list         function-url-scheme-disallowed-list
 1:1  ×  Unknown rule unit-allowed-list                           unit-allowed-list
 1:1  ×  Unknown rule declaration-property-value-disallowed-list  declaration-property-value-disallowed-list

[josephperrott]

LGTM

We should also make this error exit with a non-zero code

[crisbeto]

I don't think we can do much about the exit code, it's just what Stylelint decided to exit with.

[googlebot]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[josephperrott]

@crisbeto played with it for a second and found how the way to set it to fail if these things are found. Pushed it up as a fixup.

[googlebot]

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

[crisbeto]

Nice! I don't know whether we handle fixup commits in this repo though.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}